slachiewicz opened a new pull request, #1518: URL: https://github.com/apache/maven-release/pull/1518
`AbstractRewritePomsPhase.transformDocument` walked the DomTrip model through the Maven 3 model classes and converted each list with `toMavenCoordinates`. It now works on small read-through views (`PomModel`, `PomModelBase`, `PomBuild`, `PomBuildBase`, `PomPlugin`, `PomProfile`), with the method names the Maven 4 port uses, so the port keeps this method and drops `extends Model` from the DomTrip classes instead. The four copies of the plugin and plugin-management loops become one `rewriteBuildPlugins`; the edit order is unchanged. The DomTrip classes cannot implement the views directly while they extend the Maven 3 model (`getDependencies()` would need two return types), so `DomTripPomViews` wraps them. `ModelETL` gains `getPomModel()` as a default method that throws `UnsupportedOperationException`, so other implementations still compile. The new types are `@since 3.4.0`, so this needs the next release to be a minor. Part of apache/maven#13309. Verified: `mvn verify` → manager module 773 tests (4 new), 0 failures; the expected-POM rewrite tests pass unchanged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
