slachiewicz opened a new pull request, #167: URL: https://github.com/apache/maven-scm-publish-plugin/pull/167
The plugin depended on maven-release-manager only for `ScmRepositoryConfigurator.getConfiguredRepository`. That logic now lives in a package-private `ScmRepositoryFactory`, ported from maven-release 3.3.1: server lookup by id then by `host[:port]`, explicit credentials winning over the server's, and password and passphrase decrypted through Maven's `SettingsDecrypter` (used as is, with a warning, when decryption fails). maven-release-manager and maven-release-api go, and with them maven-invoker, jdom2 and Resolver on the plugin classpath; maven-scm-manager-plexus, previously transitive, is declared as runtime. The unreleased `AbstractScmPublishMojo(ScmManager, ScmRepositoryConfigurator)` constructor and its field become `(ScmManager, SettingsDecrypter)`; 3.3.0 field-injected the configurator. Behaviour is unchanged except for log text: the decryption warning carries the sec-dispatcher message and goes through the mojo log. Part of apache/maven#13309. Verified: a throwaway harness comparing the old configurator with the new factory over 259,200 combinations of server layout, credentials, encryption state, `pushChanges` and interactive mode → identical; `mvn verify -Prun-its` → 19 new unit tests, all 5 ITs passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
