slachiewicz opened a new pull request, #1514: URL: https://github.com/apache/maven-release/pull/1514
The settings file handed to the forked or Invoker Maven build was written with `FileWriter`, in the platform charset, while its XML header declares UTF-8, so non-ASCII content was corrupted on a non-UTF-8 default. Both executors now write UTF-8. The new test only proves something under a non-UTF-8 default, and JDK 18+ defaults to UTF-8, so it also runs in a dedicated surefire execution with `-Dfile.encoding=ISO-8859-1`; the other tests keep their environment. Found while porting to the Maven 4 API; part of apache/maven#13309. Verified: `testSettingsFileIsWrittenInUtf8` fails in the `settings-charset` execution without the fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
