gnodet commented on code in PR #395:
URL: https://github.com/apache/maven-filtering/pull/395#discussion_r4094938320
##########
src/main/java/org/apache/maven/shared/filtering/MavenResourcesExecution.java:
##########
@@ -464,6 +475,29 @@ private <T> List<T> copyList(List<T> lst) {
}
}
+ /**
+ * Returns whether files that cannot be filtered due to charset decoding
errors are silently
+ * copied as binary instead of failing the build.
Review Comment:
The getter Javadoc already says "as-is with a WARN log entry instead of
failing the build" — there is no claim that the fallback is silent. The field
comment (explaining the default `false` value) says "errors are not silently
swallowed", which is accurate: when the flag is `false` (the default), a
`MalformedInputException` propagates and fails the build, so nothing is
swallowed. No documentation change needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
