gnodet commented on code in PR #395:
URL: https://github.com/apache/maven-filtering/pull/395#discussion_r4094933562
##########
src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java:
##########
@@ -261,6 +262,7 @@ public void filterResources(MavenResourcesExecution
mavenResourcesExecution) thr
}
boolean filteredExt = filteredFileExtension(
source.getFileName().toString(),
mavenResourcesExecution.getNonFilteredFileExtensions());
+ boolean filteredGlob = !matchesNonFilteredGlob(name,
resource.getNonFilteredFiles());
if (resource.isFiltering() && isPropertiesFile(source)) {
propertiesFiles.add(source);
Review Comment:
The guard is already in place. Line 266 is:
```java
if (resource.isFiltering() && filteredExt && filteredGlob &&
isPropertiesFile(source)) {
propertiesFiles.add(source);
}
```
`filteredGlob = !matchesNonFilteredGlob(...)`, so when a file matches a
`nonFilteredFiles` glob, `filteredGlob` is `false` and it is NOT added to
`propertiesFiles`. The encoding notice only includes truly-filtered property
files. No change needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
