efegokdemir opened a new pull request, #1215: URL: https://github.com/apache/maven-plugin-tools/pull/1215
### Rationale for this change `HtmlToPlainTextConverter` only used Jsoup's absolute URL resolution, so relative page links in generated help descriptions were rendered without their target. Preserve relative `href` values while continuing to omit fragment-only anchors. ### What changes are included in this PR? - Fall back to the original `href` when Jsoup cannot resolve an absolute URL. - Keep fragment-only links out of the plain-text URL suffix. - Add regression coverage for relative page links. ### Are these changes tested? - `mvn -pl maven-plugin-tools-generators -Dspotless.check.skip=true -Dspotless.apply.skip=true test` — passed (18 tests, 1 skipped). - `mvn -pl maven-plugin-tools-generators -Dspotless.check.skip=true -Dspotless.apply.skip=true verify` — passed. - `git diff --check` — passed. - Spotless could not run locally on JDK 27 because its formatter fails with `NoSuchFieldError` in `com.sun.tools.javac.tree.JCTree`; the repository checks and tests pass with only the formatter checks skipped. ### Are there any user-facing changes? Relative links in generated plugin help text now include their targets, matching absolute links. Closes #822 AI assistance was used in preparing this contribution; the submitting contributor reviewed the changed lines, tests, and final diff. - [x] I hereby declare that this code conforms to the Apache Software Foundation's [Code of Conduct](https://www.apache.org/foundation/policies/conduct) - [x] I have read and understand the [contribution guidelines](https://github.com/apache/maven-plugin-tools/blob/master/CONTRIBUTING.md) - [x] I have tested the changes in this PR - [x] I have opened an issue for this PR and linked it in the description,--web -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
