efegokdemir opened a new pull request, #439: URL: https://github.com/apache/maven-help-plugin/pull/439
## Summary `help:effective-settings -DshowPasswords=true` currently passes Maven's live `Settings` object to cleanup code, which replaces each profile's properties with a sorted copy. This mutates shared Maven state during report generation. ## Changes - Always serialize a defensive settings copy, including when passwords are shown. - Deep-copy profile objects and their properties so cleanup remains isolated from the caller. - Add a regression test for the `showPasswords` path. ## Testing - `mvn -B -DskipITs -Dspotless.check.skip=true -Dspotless.apply.skip=true test` — passed (31 tests). - `JAVA_HOME=/opt/homebrew/Cellar/openjdk@21/21.0.12.1/libexec/openjdk.jdk/Contents/Home PATH="$JAVA_HOME/bin:$PATH" mvn -B spotless:check` — passed. - `git diff --check` — passed. - The focused regression test failed on the unchanged implementation and passed after the fix. Fixes #385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
