Tarun4201 commented on PR #13254:
URL: https://github.com/apache/maven/pull/13254#issuecomment-5800103964
All review feedback has been addressed. The PR is now clean — **2 commits on
top of current `master`**:
1. `[MNG-6787] Fix activeByDefault profile not deactivated when -P specified`
- `DefaultProfileSelector.java`: defer external `activeByDefault`
profiles into a separate list; only include them when no profile is explicitly
activated via `-P`
- Inline comments document the intentional semantic asymmetry between
`activatedPomProfileNotByDefault` (any POM activation) and
`anyProfileExplicitlyActivated` (strict `-P` only)
2. `[MNG-6787] Add missing 4th test: POM -P also suppresses external
activeByDefault`
- `DefaultProfileSelectorTest.java` in `impl/maven-impl` with 4 tests:
- External explicit `-P` suppresses external `activeByDefault` ✅
- POM explicit `-P` also suppresses external `activeByDefault` ✅
- No `-P` → external `activeByDefault` remains active ✅
- POM `activeByDefault` suppressed when another POM profile activated
(regression guard) ✅
Note: the GitHub UI may still show a stale commit count — the actual branch
contains only 2 commits above `master` (force-pushed clean from upstream).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
