Tarun4201 commented on PR #13254: URL: https://github.com/apache/maven/pull/13254#issuecomment-5800057042
Addressed all review feedback — here is a summary of the changes made in the latest push: --- **1. Rebased onto current `master`** The old branch contained commits from MNG-8056 (already merged via #13248) which inflated the diff. The branch is now a clean single commit on top of the latest upstream `master` — only 2 files changed. **2. Unit tests added in `impl/maven-impl`** Added `DefaultProfileSelectorTest` directly on `org.apache.maven.impl.model.DefaultProfileSelector` (not the legacy compat one) with **4 tests**: - `externalActiveByDefaultSuppressedWhenProfileExplicitlyActivated` — external `-P` suppresses external default - `externalActiveByDefaultSuppressedWhenPomProfileExplicitlyActivated` — POM `-P` also suppresses external default - `externalActiveByDefaultReturnedWhenNoProfileExplicitlyActivated` — no `-P` keeps external default active - `pomActiveByDefaultSuppressedWhenOtherPomProfileExplicitlyActivated` — regression guard for existing POM behaviour **3. Semantic asymmetry documented** Added inline comments above both boolean flags explaining the intentional difference: - `activatedPomProfileNotByDefault` fires on *any* POM profile activation (explicit or condition-based) - `anyProfileExplicitlyActivated` fires only on strict `-P` / `--activate-profiles` This is the behaviour required by the MNG-6787 spec and is now self-documenting in code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
