gnodet commented on code in PR #13249:
URL: https://github.com/apache/maven/pull/13249#discussion_r4084575692
##########
impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/mvn/MavenParser.java:
##########
@@ -76,6 +174,21 @@ protected MavenOptions parseMavenAtFileOptions(Path atFile)
{
}
}
+ protected MavenOptions parseMavenReactorOptions(List<String> args) {
+ try {
+ MavenOptions options = parseArgs("reactor.xml", args);
+ if (options.goals().isPresent()) {
+ // <options> can only contain options, not goals/phases
+ throw new IllegalArgumentException("Unrecognized entries in
reactor.xml <options>: "
+ + options.goals().get());
+ }
+ return options;
+ } catch (ParseException e) {
+ throw new IllegalArgumentException(
+ "Failed to parse arguments from reactor.xml <options>: " +
e.getMessage(), e.getCause());
Review Comment:
Fixed in 1802942432: changed `e.getCause()` to `e` so the original
`ParseException` is preserved as the cause of the `IllegalArgumentException`.
The pre-existing occurrences at lines 160/171/206 use `e.getCause()` for
historical reasons but this new call is now consistent with preserving the full
stack trace.
##########
api/maven-api-spi/src/main/java/org/apache/maven/api/spi/LifecycleProcessor.java:
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.api.spi;
+
+import org.apache.maven.api.Lifecycle;
+import org.apache.maven.api.annotations.Consumer;
+import org.apache.maven.api.annotations.Experimental;
+import org.apache.maven.api.annotations.Nonnull;
+import org.apache.maven.api.di.Named;
+
+/**
+ * SPI for transforming Maven lifecycles at session initialisation time.
+ *
+ * <p>A {@code LifecycleProcessor} receives each built-in (or
extension-contributed) lifecycle
+ * and may return a modified version of it — for example to inject additional
phases into the
+ * lifecycle DAG. Multiple processors are applied in order; each one receives
the output of the
+ * previous one.
+ *
+ * <p>Processors are called once per lifecycle per session, after the base
lifecycles have been
+ * assembled by the {@link LifecycleProvider}s, so they have access to full
session context.
+ *
Review Comment:
Fixed in 1802942432: corrected the Javadoc to state that processors are
called each time the lifecycle phase map is rebuilt (not once per session), and
that implementations must be stateless and idempotent.
##########
api/maven-api-spi/src/main/java/org/apache/maven/api/spi/LifecycleProcessor.java:
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.api.spi;
+
+import org.apache.maven.api.Lifecycle;
+import org.apache.maven.api.annotations.Consumer;
+import org.apache.maven.api.annotations.Experimental;
+import org.apache.maven.api.annotations.Nonnull;
+import org.apache.maven.api.di.Named;
+
+/**
+ * SPI for transforming Maven lifecycles at session initialisation time.
+ *
+ * <p>A {@code LifecycleProcessor} receives each built-in (or
extension-contributed) lifecycle
+ * and may return a modified version of it — for example to inject additional
phases into the
+ * lifecycle DAG. Multiple processors are applied in order; each one receives
the output of the
+ * previous one.
+ *
+ * <p>Processors are called once per lifecycle per session, after the base
lifecycles have been
+ * assembled by the {@link LifecycleProvider}s, so they have access to full
session context.
+ *
+ * <p>Example — injecting a {@code docker-push} phase after {@code deploy}:
+ * <pre>{@code
+ * @Named
+ * public class DockerLifecycleProcessor implements LifecycleProcessor {
+ * public Lifecycle process(Lifecycle lifecycle) {
+ * if (!Lifecycle.DEFAULT.equals(lifecycle.id())) return lifecycle;
+ * return LifecycleProcessor.withInjectedPhase(lifecycle,
+ * "docker-push", "deploy", null);
Review Comment:
Fixed in 1802942432: replaced the non-existent
`LifecycleProcessor.withInjectedPhase()` call with `new
PhaseEnrichedLifecycle(...)` using the actual constructor. Added a comment
noting that `PhaseEnrichedLifecycle` lives in `impl/maven-core` since it's an
implementation class, not part of the public API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
