slachiewicz commented on code in PR #760:
URL:
https://github.com/apache/maven-invoker-plugin/pull/760#discussion_r4055086885
##########
src/site/markdown/examples/pre-post-build-script.md.vm:
##########
@@ -126,6 +126,13 @@ In this case, the pre and post build hook scripts can be
executed for each invoc
Missing script files will be ignored.
+# Script bytecode level
+
+By default, the pre-/post-build Groovy scripts are compiled to the bytecode
level of the JDK running Maven. Set the
+[`scriptTargetBytecode`](../run-mojo.html#scriptTargetBytecode) parameter (or
the `maven.compiler.release` /
Review Comment:
Moved the default out of the annotation in e07fdad. The order is now
parameter → `maven.compiler.release` → `maven.compiler.target`, each looked up
in `-D` properties and then the project, which is what the `${...}` default
did; the site page now states that order instead of calling the running JDK the
default.
An empty value cannot opt out, with or without a `defaultValue`.
`<scriptTargetBytecode/>` gets the descriptor value merged in
(`Xpp3Dom.mergeXpp3Dom` fills an empty dominant value from the recessive one),
and `-Dinvoker.scriptTargetBytecode=` arrives as `""`, indistinguishable from
unset. The opt-out is an explicit value, e.g.
`<scriptTargetBytecode>${java.specification.version}</scriptTargetBytecode>`;
documented on the page and in the parameter javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
