gnodet-bot commented on code in PR #12694:
URL: https://github.com/apache/maven/pull/12694#discussion_r4048599366
##########
impl/maven-core/src/main/resources/org/apache/maven/lifecycle/plugin-versions.properties:
##########
@@ -17,19 +17,19 @@
# Default lifecycle plugin versions.
# Values are substituted by Maven resource filtering at build time from
-# POM properties (lifecycle.<name>-plugin), making them visible to
+# POM properties (version.maven-<name>-plugin), making them visible to
# dependency-update bots such as Dependabot and Renovate.
-lifecycle.maven-clean-plugin=${lifecycle.maven-clean-plugin}
-lifecycle.maven-compiler-plugin=${lifecycle.maven-compiler-plugin}
-lifecycle.maven-deploy-plugin=${lifecycle.maven-deploy-plugin}
-lifecycle.maven-ear-plugin=${lifecycle.maven-ear-plugin}
-lifecycle.maven-ejb-plugin=${lifecycle.maven-ejb-plugin}
-lifecycle.maven-install-plugin=${lifecycle.maven-install-plugin}
-lifecycle.maven-jar-plugin=${lifecycle.maven-jar-plugin}
-lifecycle.maven-plugin-plugin=${lifecycle.maven-plugin-plugin}
-lifecycle.maven-rar-plugin=${lifecycle.maven-rar-plugin}
-lifecycle.maven-resources-plugin=${lifecycle.maven-resources-plugin}
-lifecycle.maven-site-plugin=${lifecycle.maven-site-plugin}
-lifecycle.maven-surefire-plugin=${lifecycle.maven-surefire-plugin}
-lifecycle.maven-war-plugin=${lifecycle.maven-war-plugin}
+version.maven-clean-plugin=${version.maven-clean-plugin}
+version.maven-compiler-plugin=${version.maven-compiler-plugin}
+version.maven-deploy-plugin=${version.maven-deploy-plugin}
+version.maven-ear-plugin=${version.maven-ear-plugin}
+version.maven-ejb-plugin=${version.maven-ejb-plugin}
+version.maven-install-plugin=${version.maven-install-plugin}
+version.maven-jar-plugin=${version.maven-jar-plugin}
+version.maven-plugin-plugin=${version.maven-plugin-plugin}
+version.maven-rar-plugin=${version.maven-rar-plugin}
+version.maven-resources-plugin=${version.maven-resources-plugin}
+version.maven-site-plugin=${version.maven-site-plugin}
+version.maven-surefire-plugin=${version.maven-surefire-plugin}
+version.maven-war-plugin=${version.maven-war-plugin}
Review Comment:
**[high] Rebase conflict: `version.*` key names don't match POM properties —
CI fails on class load**
The properties file references `${version.maven-*-plugin}` placeholders, but
the POM declares `<lifecycle.maven-*-plugin>` properties (e.g.
`<lifecycle.maven-ejb-plugin>3.3.0</lifecycle.maven-ejb-plugin>`). Maven
resource filtering substitutes `${lifecycle.maven-ejb-plugin}` but leaves
`${version.maven-ejb-plugin}` as a literal string, so
`PluginVersions.version()` throws:
```
ExceptionInInitializerError: plugin-versions.properties was not filtered at
build time;
version.maven-ejb-plugin still contains placeholder:
${version.maven-ejb-plugin}
```
This brings down `DefaultLifecycleRegistry$CleanLifecycle` at static init
time, causing 100+ test failures across `maven-core`.
The fix is to rename both the property file keys and the
`PluginVersions.java` key prefix from `version.*` to `lifecycle.*`, aligning
with the POM property names that master uses:
```suggestion
# POM properties (lifecycle.<name>-plugin), making them visible to
# dependency-update bots such as Dependabot and Renovate.
lifecycle.maven-clean-plugin=${lifecycle.maven-clean-plugin}
lifecycle.maven-compiler-plugin=${lifecycle.maven-compiler-plugin}
lifecycle.maven-deploy-plugin=${lifecycle.maven-deploy-plugin}
lifecycle.maven-ear-plugin=${lifecycle.maven-ear-plugin}
lifecycle.maven-ejb-plugin=${lifecycle.maven-ejb-plugin}
lifecycle.maven-install-plugin=${lifecycle.maven-install-plugin}
lifecycle.maven-jar-plugin=${lifecycle.maven-jar-plugin}
lifecycle.maven-plugin-plugin=${lifecycle.maven-plugin-plugin}
lifecycle.maven-rar-plugin=${lifecycle.maven-rar-plugin}
lifecycle.maven-resources-plugin=${lifecycle.maven-resources-plugin}
lifecycle.maven-site-plugin=${lifecycle.maven-site-plugin}
lifecycle.maven-surefire-plugin=${lifecycle.maven-surefire-plugin}
lifecycle.maven-war-plugin=${lifecycle.maven-war-plugin}
```
Also update `PluginVersions.java` line `String key = "version." +
pluginArtifactId;` → `String key = "lifecycle." + pluginArtifactId;` and the
Javadoc comment in the same file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
