gnodet-bot commented on code in PR #13163:
URL: https://github.com/apache/maven/pull/13163#discussion_r4038704453
##########
impl/maven-impl/src/test/java/org/apache/maven/impl/model/profile/ConditionProfileActivatorTest.java:
##########
@@ -401,13 +401,14 @@ void testFileRootDirectory() {
}
@Test
- @Disabled
void testFileWilcards() {
assertActivation(true,
newProfile("exists('${project.rootDirectory}/**/*.xsd')"), newFileContext());
assertActivation(true,
newProfile("exists('${project.basedir}/**/*.xsd')"), newFileContext());
assertActivation(true,
newProfile("exists('${project.basedir}/**/*.xsd')"), newFileContext());
Review Comment:
🔁 **Duplicate assertion** — this line is identical to the one above it (line
406): `exists('${project.basedir}/**/*.xsd')`. Both were carried over from the
pre-existing `@Disabled` block. One of them should be removed, or the second
should test a different expression (e.g. `${project.rootDirectory}/**/*.xsd`
with an absolute path, or a `?` wildcard).
```suggestion
assertActivation(true,
newProfile("exists('${project.rootDirectory}/**/*.xsd')"), newFileContext());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
