Dev-next-gen commented on PR #13160:
URL: https://github.com/apache/maven/pull/13160#issuecomment-5708168414
Thank you for the review — the walk through the edge cases (`lastSep < 0`,
the trailing separator, the final `replace('\\', '/')`) is exactly what I would
have wanted checked.
On the JIRA ticket: I cannot file one. ASF Jira no longer accepts
self-registration — the login page ends with *"Not a member? To request an
account, please contact your Jira administrators."* and there is no public
signup form behind it. So an outside contributor has no way to obtain an MNG
number on their own. I am happy to rename the title to `[MNG-XXXXXX] Fix glob
patterns in exists()/missing() profile conditions on Windows` the moment a
number exists.
On the two checkboxes: I have left them unchecked because ticking them would
claim more than I did. What I ran is in the description —
`ConditionProfileActivatorTest` and `FileProfileActivatorTest` against
`maven-impl` built from master and from this branch, on Windows 11 with JDK 17
(35 passing and 1 failing before, 36 passing and 0 failing after), and the full
`maven-impl` test module on Linux with JDK 21 (709 tests, 0 failures). What I
did not run is `mvn verify` over the whole reactor, nor the Core ITs, for which
I have no environment. I would rather report that than check a box.
If someone with an account files the ticket, or points me to the right
person to ask for one, I will update the title straight away — otherwise this
is simply where the PR stands.
Found by a defect-hunting pipeline I build and run
([Dev-next-gen](https://github.com/Dev-next-gen)), using Claude Code with
Anthropic's Claude Opus 5.
(@Dev-next-gen)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
