gnodet-bot commented on code in PR #2150:
URL: https://github.com/apache/maven-resolver/pull/2150#discussion_r4028924489
##########
maven-resolver-test-http/src/main/java/org/eclipse/aether/internal/test/util/http/HttpServer.java:
##########
@@ -336,7 +336,7 @@ public HttpServer addHttp3Connector(boolean needClientAuth,
int port) {
* @return a port number that is (at probe time) free for both TCP and UDP
*/
int findFreeTcpAndUdpPort() {
- for (int i = 0; i < 20; i++) {
+ for (int i = 0; i < 100; i++) {
Review Comment:
⚠️ **Magic number, no rationale.** Why 100 specifically? Without an
explanation, the next person touching this has no context for the choice. Add a
comment documenting that this was increased from 20 because busy CI hosts
exhausted 20 attempts (MRESOLVER-2142).
```suggestion
for (int i = 0; i < 100; i++) { // 100 retries: on busy CI hosts 20
retries was insufficient (MRESOLVER-2142)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
