gnodet commented on PR #13086: URL: https://github.com/apache/maven/pull/13086#issuecomment-5686016034
Addressing the second finding from the latest review regarding the `FATAL` escalation for explicit `<relativePath>`: The escalation is intentional and was explicitly requested in [gnodet's review](https://github.com/apache/maven/pull/13086#pullrequestreview-5214036625), which proposed exactly this code: ```java Severity severity = (parent.getRelativePath() == null) ? Severity.WARNING : Severity.FATAL; ``` The rationale: when a developer *explicitly* writes `<relativePath>../pom.xml</relativePath>` and it resolves to a POM with the wrong GA, that is unambiguously a configuration error — the developer made an explicit, wrong declaration. The historical `WARNING` was too soft for this case and allowed builds to silently use the wrong parent. The `FATAL` brings the compat layer in line with Maven 4's `DefaultModelBuilder.mismatchRelativePathAndGA()`, which also distinguishes the two cases. The PR description has been updated to document this intentional scope expansion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
