gnodet commented on PR #13086: URL: https://github.com/apache/maven/pull/13086#issuecomment-5685924962
Addressing the latest `gnodet-bot` review (2026-09-15T18:28): **1. `assertFalse` nit** — already applied in commit `f99a00c02b` (the commit immediately after `f4fa8c0b74`). The current code uses `assertFalse(hasFatalMismatch, ...)` as suggested. **2. FATAL escalation for explicit `<relativePath>`** — intentional by design. gnodet explicitly proposed the WARNING/FATAL split in his 18:11 review, mirroring the Maven 4 `DefaultModelBuilder.mismatchRelativePathAndGA()` pattern (`boolean warn = ... || childModel.getParent().getRelativePath() == null;`). gnodet approved the resulting implementation at 18:26 after verifying both tests pass locally. The FATAL for explicit mismatches is a deliberate correctness improvement: if a developer explicitly wrote `<relativePath>../pom.xml</relativePath>` pointing at the wrong GA, that is an unambiguous configuration error. The compat layer should be strict here — silent wrong-parent usage is worse than a build failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
