kratos0718 commented on PR #166: URL: https://github.com/apache/maven-shared-jar/pull/166#issuecomment-5683379925
@elharo wanted to make sure I address this right — as of the current commit, the try covers the entries list, sort, manifest read, and the JarData construction, with finally releasing jarFile if constructed stays false. The only thing outside it is the initial new JarFile(file) call, which can't leak anything since jarFile is never assigned if that throws. Is there a specific line still outside the try that you're seeing, or would you rather the whole constructor body be one try/finally including the JarFile open itself? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
