kriegaex commented on PR #110:
URL: 
https://github.com/apache/maven-shade-plugin/pull/110#issuecomment-5629942066

   @michael-o I just found this PR again, because it is related to the recently 
closed #108. A quick check in the current source code reveals that my 
improvements from 
https://github.com/apache/maven-shade-plugin/pull/110#issuecomment-1455059620, 
which you had explicitly requested in your code review but then left unmerged 
are still missing in the code base. Would you mind committing them? I see no 
reason why we would both agree on the benefit of a change and then not bring it 
into the product. Thank you very much.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to