slachiewicz commented on PR #377:
URL: 
https://github.com/apache/maven-shared-utils/pull/377#issuecomment-5615031581

   Closing this in favour of deprecating the package instead, per the review 
here.
   
   The blocker is that `org.apache.maven.shared.utils.logging` is exported by 
Maven up to 3.9.x and many plugins compile against it, so changing the ANSI 
provider underneath it is not a safe change to make in this library. Maven 
3.10.0 introduces `org.apache.maven.message.MessageBuilderFactory` (and Maven 4 
`org.apache.maven.api.services.MessageBuilderFactory`) as the replacement, so 
the path forward is to point users there rather than re-plumb this code.
   
   That deprecation is now up as [PR 
#423](https://github.com/apache/maven-shared-utils/pull/423), which also closes 
[#373](https://github.com/apache/maven-shared-utils/issues/373).
   
   Thanks for the patch, and sorry it did not land -- the constraint only 
surfaced in review. The Java 8 analysis you did on `org.jline:jansi` 3.25.1 is 
still useful and is worth keeping on 
[#373](https://github.com/apache/maven-shared-utils/issues/373) for whoever 
revisits the provider question in a Maven 4-only line.
   
   Your branch `fix/#373` is on your fork, so please delete it there when 
convenient -- committers cannot remove it from here.
   
   *This comment was created with AI assistance.*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to