gnodet commented on PR #13081:
URL: https://github.com/apache/maven/pull/13081#issuecomment-5614564542
CI has been approved and is running. Status so far:
- **All 9 full-build jobs**: ✅ passed (all platforms, JDK 17/21/25)
- **integration-tests (ubuntu 21, 25)**: ✅ passed
- **integration-tests (macos 17)**: ❌ infra failure ("Set up JDK 17" step
failed — not related to this PR)
- **Remaining integration-tests**: still in progress
The second commit addresses all review feedback cleanly:
1. Variable renames (`depMgmt` → `dependencyManagement`, etc.)
2. `resolveImportModel()` extracted, removing the `@SuppressWarnings`
3. `importResult` declaration moved inside the try block
4. Cycle diagnostic updated to "The import POMs form a cycle"
5. New cycle-detection tests in both builders
Looks good. I'll re-check once the remaining integration tests complete.
_This comment was generated by an AI agent, Hermès on behalf of @gnodet._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
