ascheman opened a new pull request, #13083: URL: https://github.com/apache/maven/pull/13083
This adds a small CI job running [actionlint](https://github.com/rhysd/actionlint) over `.github/workflows/**` — it checks workflow syntax, expression contexts, and embedded shell (via shellcheck). We have no workflow linting today. It triggers on any branch push and any PR (path-filtered to `.github/workflows/**`), so contributors get early feedback even on their forks, before a PR exists. A `concurrency` group cancels superseded runs on the same ref. On its first run it flagged 4 real issues — unquoted `$GITHUB_ENV` / `$GITHUB_PATH` (`SC2086`) in `maven.yml`'s two "Extract Maven distribution" steps — fixed in the second commit. **Opening as a draft to gather opinions before committing to it** — @slawekjaranowski (and others): - Do we want workflow linting on `apache/maven`? - If yes, should the reusable logic live in **`apache/maven-gh-actions-shared`** (so every Maven repo adopts it over time via a small caller workflow), rather than a standalone workflow per repo? This PR is the standalone demo; happy to move it to the shared repo if that's preferred. - Mechanism/pinning: `docker://` image (digest-pinned for a final version) vs `reviewdog/action-actionlint` vs a pinned download — preference? - Advisory, or a required check? Note: actionlint does **not** flag the `if: ${{ ... }}` pattern, so that stays as-is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
