slachiewicz commented on issue #184: URL: https://github.com/apache/maven-reporting-impl/issues/184#issuecomment-5226972453
Recording the exact remaining work here, so this issue is self-contained once the Doxia side lands. **Blocked on:** apache/maven-doxia#1073, which moves `SinkEventAttributeSet` into `doxia-sink-api`. Targeted at Doxia 2.2.0. **When Doxia 2.2.0 is released**, this is finished by bumping `doxiaVersion` and changing one import in `AbstractMavenReportRenderer`: ```diff -import org.apache.maven.doxia.sink.impl.SinkEventAttributeSet; +import org.apache.maven.doxia.sink.SinkEventAttributeSet; ``` The single use is `sink.verbatim(SinkEventAttributeSet.SOURCE)` in `verbatimSource()`, and it is the only reference to `org.apache.maven.doxia.sink.impl` left in this component. The constants are the same objects under either name, so nothing else changes. **Worth doing at the same time, and arguably more urgent than the package hygiene:** `SinkEventAttributeSet.SOURCE` does not exist in Doxia 1, where it is called `BOXED`. Since a report plugin renders with whatever Doxia the Maven Site Plugin provides, `verbatimSource()` fails with a `NoSuchFieldError` under any Site Plugin older than 3.21.0 — the same failure mode as apache/maven-project-info-reports-plugin#103, which #243 has just fixed for `verbatimText`/`verbatimLink`. maven-plugin-report-plugin calls `verbatimSource()`, so this is reachable in practice, not hypothetical. Moving the class does not fix that on its own: `SOURCE` versus `BOXED` is a Doxia 1 versus 2 difference, not a packaging one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
