slachiewicz commented on issue #184: URL: https://github.com/apache/maven-reporting-impl/issues/184#issuecomment-5226583550
Filed the Doxia ticket Michael asked for back in 2024, and drafted the change: apache/maven-doxia#1072, PR apache/maven-doxia#1073. A few things that came out of looking into this: **The scope here is now one line.** `sink.verbatim(SinkEventAttributeSet.SOURCE)` in `verbatimSource()` is the only reference to `org.apache.maven.doxia.sink.impl` left in this component. MSHARED-1182 dropped the `BOXED` usage and MSHARED-1185 added `verbatimSource()`, so this has been the whole of it for a while. **This component cannot fix it on its own.** `doxia-sink-api` has six files in it and ships no implementation of `SinkEventAttributes` and no factory for one, so `Sink.verbatim(SinkEventAttributes)` is uncallable by anyone without reaching into `doxia-core`'s impl package. That is why the fix has to be on the Doxia side. **It is not this component's doing either.** In a checkout of the Maven repositories, 14 files import that package: maven-project-info-reports-plugin, maven-changes-plugin, maven-pmd-plugin, maven-plugin-report-plugin, maven-surefire-report-plugin, dist-tool and this one. And the class was in `org.apache.maven.doxia.sink` until DOXIA-506 moved it in with the internal sink implementations, so it is a class consumers always used that got relabelled as internal, not one they reached into. **One correction to the original report.** It says the constants lost their effect when DOXIA-685 replaced `BOXED` with `SOURCE`. That is not true of `SOURCE` today: `Xhtml5BaseSink.verbatim(SinkEventAttributes)` in 2.1.0 still evaluates `DECORATION` and emits `<pre><code>` for it, and `src/it/use-as-direct-mojo` asserts exactly that output. So there is no behavioural bug to fix here, only the package dependency. Once the Doxia change is released this becomes a one-line import change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
