gnodet opened a new pull request, #12702:
URL: https://github.com/apache/maven/pull/12702

   ## Summary
   
   Follow-up to the build report / warning mode chain. This PR implements the 
structured `BuilderProblem` pipeline for the 4 pathways identified in the 
foundation work, plus a full migration of the `PluginValidationManager` 
interface.
   
   ### Commit 1: Pipe structured BuilderProblems into DiagnosticCollector 
(Pathways 1–4)
   
   **Pathway 2 — Plugin parameter validation** 
(`AbstractMavenPluginParametersValidator`): 3 validators now create 
`BuilderProblem` with structured key, severity, and suggestion, and pipe 
through `PluginValidationManager` → `DiagnosticCollector`.
   
   **Pathway 3 — Plugin dependency validation** 
(`AbstractMavenPluginDependenciesValidator`): 4 validators now create 
`BuilderProblem` with structured key and pipe through `PluginValidationManager` 
→ `DiagnosticCollector`.
   
   **Pathway 4 — Plugin manager Contextualizable check** 
(`DefaultMavenPluginManager`): creates `BuilderProblem` with key 
`plugin-validation:contextualizable` and pipes through 
`PluginValidationManager` → `DiagnosticCollector`.
   
   ### Commit 2: Migrate PluginValidationManager to native BuilderProblem API
   
   - Changed `PluginValidationManager` interface: 3 abstract methods now accept 
`BuilderProblem` instead of `String`
   - Added `@Deprecated(since = "4.1.0", forRemoval = true)` String-based 
default methods as backward-compat adapters
   - Updated all 9 call sites across 8 files to create `BuilderProblem` natively
   
   ## PR chain
   
   - #12694 → #12695 → #12697 → #12698 → **this PR**
   - #12699 also targets #12698
   
   ## Test plan
   
   - [x] `mvn test -pl impl/maven-core` — tests pass
   - [ ] CI
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to