wilx opened a new pull request, #1150:
URL: https://github.com/apache/maven-plugin-tools/pull/1150
## Summary
Replace the annotation extractor's QDox-backed Java source model with
JavaParser and its symbol solver. This fixes descriptor generation for
comment-only Java source files while retaining Javadoc extraction, reference
resolution, and link generation.
Fixes #718.
## Implementation
- Add a JavaParser source model that resolves project sources, reactor
output directories, dependency JARs, and the complete Java class library.
- Port Mojo and parameter Javadoc extraction, member lookup, static-field
values, module lookup, and internal/external link resolution from QDox to
JavaParser.
- Keep directory and JAR classpath entries visible through one class loader
with platform-module delegation.
- Add regression coverage for comment-only sources, mixed reactor/JAR
inheritance, JDK platform modules, generated sources, and observable
source-root exclusion.
- Remove the annotation extractor's direct QDox dependency and update the
dependency diagram.
The user-visible result is that valid projects containing a `.java` file
with only comments no longer fail during the `descriptor` goal. Existing
Javadoc metadata and links continue to be generated through the new model.
## Validation
- `JAVA_HOME=/opt/jdks/latest-17 mvn spotless:apply`
- `JAVA_HOME=/opt/jdks/latest-17 mvn -Prun-its verify`
- Maven Plugin Plugin ITs: 31 passed, 1 Maven-version-specific test skipped
- Maven Plugin Report Plugin ITs: 12 passed
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
