elharo commented on PR #379: URL: https://github.com/apache/maven-antrun-plugin/pull/379#issuecomment-5202915910
This change breaks existing projects that rely on the aggregate dependencies reference. * The `DependencyFilesetsTask` previously exported the aggregate project dependencies (using the default ID `maven.project.dependencies` or a custom prefix) as an Ant `FileSet`. * The provided patch changes the underlying Java object of this reference from `org.apache.tools.ant.types.FileSet` to `org.apache.tools.ant.types.resources.Union`, which is a `ResourceCollection`. * Existing Ant build XML configurations that reference this collection using the `<fileset refid="maven.project.dependencies"/>` syntax will fail because the referenced object is no longer a valid `FileSet`. * To resolve this break, users must update their Ant scripts to use the `<resources refid="maven.project.dependencies"/>` element instead of `<fileset>`. * This required syntax modification is explicitly demonstrated in the patch's updates to both the integration test (`src/it/filesets-test/pom.xml`) and the documentation (`src/site/apt/tasks/dependencyFilesets.apt.vm`). The architectural purpose of this change is to alter how the dependency paths are resolved. By assembling the `Union` resource collection from the actual resolved artifact files, the plugin can now successfully include artifacts located outside the local Maven repository, such as reactor inter-module dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
