elharo opened a new pull request, #379: URL: https://github.com/apache/maven-antrun-plugin/pull/379
## Fixes https://github.com/apache/maven-antrun-plugin/issues/373 ## Summary The aggregate `maven.project.dependencies` reference was a `FileSet` rooted at the local repository, using `localRepository.pathOf(artifact)` for its include patterns. Artifacts that are not physically in the local repository (notably reactor inter-module dependencies, resolved to a sibling module's output) silently matched nothing, so the aggregate was incomplete in reactor builds. The aggregate is now built from the actual resolved artifact files, the same way the per-dependency filesets are: a `Union` of per-artifact `FileSet`s, each rooted at `artifact.getFile()`. Artifacts from any location are now included. ## Breaking change The aggregate reference is now a resource collection (`org.apache.tools.ant.types.resources.Union`) rather than a `FileSet`. Consuming it in Ant XML requires `<resources refid="maven.project.dependencies"/>` (or `<union refid=...>`) instead of `<fileset refid="maven.project.dependencies"/>`. The docs and the `filesets-test` IT were updated accordingly. Note: `<property refid="maven.project.dependencies"/>` (as in the `MANTRUN-192` IT) keeps working unchanged. ## Changes - `DependencyFilesetsTask.java`: build the aggregate as a `Union` of per-artifact `FileSet`s from `artifact.getFile()`; drop the local-repository-based `FileSet` and the now-unneeded empty-artifacts special case. - New unit test `DependencyFilesetsTaskAggregateTest` covering an artifact outside the local repository. - Updated `filesets-test` IT and `dependencyFilesets.apt.vm` docs for the resource collection usage. ## Verification - New test fails on master (reactor artifact omitted from the aggregate) and passes with the fix. - `mvn verify` (rat, checkstyle, spotless, unit tests, javadoc) passes. - `mvn verify -Prun-its` passes: all 29 integration tests succeed, and `filesets-test` confirms the aggregate copies all dependencies. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
