ascheman commented on code in PR #1106:
URL:
https://github.com/apache/maven-compiler-plugin/pull/1106#discussion_r3716197799
##########
src/main/java/org/apache/maven/plugin/compiler/PathFilter.java:
##########
@@ -80,8 +83,14 @@ final class PathFilter extends SimpleFileVisitor<Path> {
private final String[] excludes;
/**
- * Combination of include and exclude filters. This is an instance of
{@link PathSelector},
- * unless the includes/excludes can be simplified to a single standard
matcher instance.
+ * The service to use for creating include and exclude filters.
+ * Used for setting a value to {@link #fileMatcher} and {@link
#directoryMatcher}.
Review Comment:
Nit: these two links are dangling — `PathFilter` has no `fileMatcher` or
`directoryMatcher` field; they are `matchers` and `incrementalExcludeMatchers`.
The names look carried over from
`PathMatcherFactory.deriveDirectoryMatcher(PathMatcher fileMatcher)`. Nothing
fails, since javadoc does not process private members.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
