wilx commented on code in PR #1668:
URL:
https://github.com/apache/maven-dependency-plugin/pull/1668#discussion_r3706103159
##########
src/main/java/org/apache/maven/plugins/dependency/fromDependencies/CopyDependenciesMojo.java:
##########
@@ -108,21 +101,16 @@ public class CopyDependenciesMojo extends
AbstractFromDependenciesMojo {
protected boolean copySignatures;
@Inject
- @SuppressWarnings("checkstyle:ParameterNumber")
public CopyDependenciesMojo(
MavenSession session,
BuildContext buildContext,
MavenProject project,
ResolverUtil resolverUtil,
- RepositoryManager repositoryManager,
Review Comment:
This ctor has already changed from no args to some args from 3.8.1 to 3.9.0.
Ctors or even the mojo implementation classes should not be considered API.
That's unreasonable for this project and its ability to evolve. This moves the
project forward. You will have to do this one way or another eventually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
