wilx commented on code in PR #1668: URL: https://github.com/apache/maven-dependency-plugin/pull/1668#discussion_r3698852311
########## src/main/java/org/apache/maven/plugins/dependency/fromConfiguration/ArtifactItem.java: ########## @@ -34,7 +33,7 @@ * @author <a href="mailto:[email protected]";>Brian Fox</a> * @since 1.0 */ -public class ArtifactItem implements DependableCoordinate { Review Comment: Are plugin's themselves considered API? We wouldn't be able to make any changes if they were impossible to change. ########## src/main/java/org/apache/maven/plugins/dependency/fromDependencies/CopyDependenciesMojo.java: ########## @@ -108,21 +101,16 @@ public class CopyDependenciesMojo extends AbstractFromDependenciesMojo { protected boolean copySignatures; @Inject - @SuppressWarnings("checkstyle:ParameterNumber") public CopyDependenciesMojo( MavenSession session, BuildContext buildContext, MavenProject project, ResolverUtil resolverUtil, - RepositoryManager repositoryManager, Review Comment: Ditto. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
