elharo opened a new pull request, #148:
URL: https://github.com/apache/maven-shared-jar/pull/148

   Fixes #144
   
   Removed the redundant `catch (ZipException)` block in the `JarAnalyzer` 
constructor. It re-wrapped the exception with a new message and a 
misleadingly-named `ioe` variable, adding no information beyond the original 
exception.
   
   The constructor already declares `throws IOException` (and `ZipException` is 
a subclass), so the original exception now propagates unchanged. Also removed 
the now-unused `java.util.zip.ZipException` import.
   
   The existing `invalidJarFile` test (which asserts `ZipException` is thrown 
for an invalid JAR) still passes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to