royteeuwen commented on code in PR #519:
URL:
https://github.com/apache/maven-build-cache-extension/pull/519#discussion_r3701800342
##########
src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java:
##########
@@ -428,15 +434,31 @@ private Path convertToAbsolutePath(Path path) {
*/
private void startWalk(
Path candidate, String glob, boolean recursive, List<Path>
collectedFiles, Set<WalkKey> visitedDirs) {
+ startWalk(candidate, glob, recursive, false, collectedFiles,
visitedDirs);
Review Comment:
Good point — removed the overload and updated the call sites to pass
`includeHidden` explicitly.
##########
src/main/java/org/apache/maven/buildcache/checksum/WalkKey.java:
##########
@@ -28,11 +28,17 @@ public class WalkKey {
private final Path normalized;
private final String glob;
private final boolean recursive;
+ private final boolean includeHidden;
public WalkKey(Path normalized, String glob, boolean recursive) {
+ this(normalized, glob, recursive, false);
Review Comment:
Done — added `@Deprecated` plus a javadoc `@deprecated` tag pointing at the
4-arg constructor. Nothing in the codebase uses the 3-arg one anymore, so it is
there purely for compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
