olamy commented on code in PR #519:
URL:
https://github.com/apache/maven-build-cache-extension/pull/519#discussion_r3698768132
##########
src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java:
##########
@@ -428,15 +434,31 @@ private Path convertToAbsolutePath(Path path) {
*/
private void startWalk(
Path candidate, String glob, boolean recursive, List<Path>
collectedFiles, Set<WalkKey> visitedDirs) {
+ startWalk(candidate, glob, recursive, false, collectedFiles,
visitedDirs);
Review Comment:
no need to keep backward compat for private methods
##########
src/main/mdo/build-cache-config.mdo:
##########
@@ -951,6 +951,15 @@ under the License.
<type>String</type>
<description>Files in a directory are filtered by matching
their names against this glob.</description>
</field>
+ <field xml.attribute="true">
Review Comment:
we usually increase model version in case of model changes (see pom.xml)
##########
src/main/java/org/apache/maven/buildcache/checksum/WalkKey.java:
##########
@@ -28,11 +28,17 @@ public class WalkKey {
private final Path normalized;
private final String glob;
private final boolean recursive;
+ private final boolean includeHidden;
public WalkKey(Path normalized, String glob, boolean recursive) {
+ this(normalized, glob, recursive, false);
Review Comment:
mark this constructor `deprecated`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
