wilx opened a new pull request, #1669:
URL: https://github.com/apache/maven-dependency-plugin/pull/1669
## Summary
When `dependency:copy-dependencies` copies an artifact, overwrite its
associated POM as well. This prevents version-stripped output from containing a
JAR from one version and a pre-existing POM from another version.
Artifacts skipped by the configured overwrite policy retain the existing
MDEP-164 behavior: their POM is copied only when it is missing.
## Root cause
Copied and skipped artifacts shared the same `copyPoms` path, which
unconditionally ignored an existing destination POM. As a result, an artifact
selected for replacement could overwrite the versionless JAR while leaving its
old versionless POM untouched.
Fixes #1370
## Verification
- The new regression test failed before the production change with
`expected: <new pom> but was: <old pom>`.
- Maven 3: `mvn verify` — 412 tests, 0 failures/errors, 1 skipped.
- Maven 4 with JDK 21: `mvn verify` — 412 tests, 0 failures/errors, 1
skipped.
- Focused Invoker build: `mvn -DskipTests -Prun-its
-Dinvoker.test=copy-dependencies verify` — 1 passed.
- Exact Commons Lang 3.12.0 to 3.14.0 reproducer: the resulting versionless
JAR and POM checksums both match 3.14.0.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
