elharo commented on code in PR #499: URL: https://github.com/apache/maven-resources-plugin/pull/499#discussion_r3695680519
########## pom.xml: ########## @@ -72,7 +72,7 @@ under the License. </distributionManagement> <properties> - <mavenVersion>4.0.0-rc-4</mavenVersion> + <mavenVersion>4.0.0-rc-5</mavenVersion> Review Comment: Update: the real root cause turned out to be apache/maven#11425, fixed in 4.0.0-rc-6: the rc-5 enhanced configurator silently fails to write *private fields* via direct field injection (field-accessibility cache leak), leaving parameters without setters at their JVM defaults. That is exactly why `escapeString`, `skip`, `buildFilters` and `useBuildFilters` were ignored in the failing ITs. This PR now adds setters for those parameters (`setSkip`, `setEscapeString`, `setBuildFilters`, `setUseBuildFilters`). The configurator prefers setter methods, which do not need `setAccessible` and therefore work on rc-4, rc-5 and rc-6 alike. All 27 ITs now pass under both 4.0.0-rc-4 and 4.0.0-rc-5. I kept `mavenVersion` at 4.0.0-rc-4 because rc-6 is not yet in Maven Central (it is still in the Apache staging repository) and the repo CI workflow runs the ITs with 4.0.0-rc-4 and cannot be changed from this PR (no `workflow` scope). Happy to bump to rc-6 (and the CI workflow) as soon as it is published. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
