elharo commented on code in PR #499:
URL:
https://github.com/apache/maven-resources-plugin/pull/499#discussion_r3695600167
##########
src/main/java/org/apache/maven/plugins/resources/TestResourcesMojo.java:
##########
@@ -50,19 +51,11 @@ public class TestResourcesMojo extends ResourcesMojo {
@Parameter
private List<Resource> resources;
- /**
- * Set this to 'true' to bypass copying of test resources.
- * Its use is NOT RECOMMENDED, but quite convenient on occasion.
- * @since 2.6
- */
- @Parameter(property = "maven.test.skip", defaultValue = "false")
Review Comment:
For compatibility reasons, the parameter can't be removed here, even if it's
use is a no-op
##########
src/main/java/org/apache/maven/plugins/resources/TestResourcesMojo.java:
##########
@@ -75,6 +68,24 @@ public void execute() throws MojoException {
super.doExecute();
}
+ /**
+ * Returns {@code true} if test resource copying should be skipped.
+ * Checks both the inherited {@code skip} parameter (bound to {@code
maven.resources.skip})
+ * and the {@code maven.test.skip} property from the session.
+ *
+ * @return {@code true} if test resources should not be copied
+ * @since 3.x
Review Comment:
remove this line
##########
pom.xml:
##########
@@ -72,7 +72,7 @@ under the License.
</distributionManagement>
<properties>
- <mavenVersion>4.0.0-rc-4</mavenVersion>
+ <mavenVersion>4.0.0-rc-5</mavenVersion>
Review Comment:
can we jump to 4.0.0-rc-6?
RC4 and RC5 compatibility are not required
##########
src/main/java/org/apache/maven/plugins/resources/TestResourcesMojo.java:
##########
@@ -75,6 +68,24 @@ public void execute() throws MojoException {
super.doExecute();
}
+ /**
+ * Returns {@code true} if test resource copying should be skipped.
+ * Checks both the inherited {@code skip} parameter (bound to {@code
maven.resources.skip})
+ * and the {@code maven.test.skip} property from the session.
+ *
+ * @return {@code true} if test resources should not be copied
+ * @since 3.x
+ */
+ protected boolean isTestSkip() {
Review Comment:
protected --> private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
