Copilot commented on code in PR #102: URL: https://github.com/apache/maven-shared-io/pull/102#discussion_r3695504694
########## src/test/java/org/apache/maven/shared/io/scan/StaleResourceScannerTest.java: ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.shared.io.scan; + +import java.io.File; +import java.util.Set; + +import org.apache.maven.shared.io.scan.mapping.SourceMapping; +import org.junit.jupiter.api.Test; + +class StaleResourceScannerTest { + + @Test + void shouldNotNpeWhenGetTargetFilesReturnsNull() throws Exception { + StaleResourceScanner scanner = new StaleResourceScanner(); + scanner.addSourceMapping(new SourceMapping() { + public Set<File> getTargetFiles(File targetDir, String source) { + return null; + } + }); + + File sourceDir = new File("src/test"); + File targetDir = new File("target"); + scanner.getIncludedSources(sourceDir, targetDir); + } Review Comment: This test relies on scanning the repository’s real `src/test` tree. That makes the test slower and less isolated (it depends on the working directory contents) and it doesn’t guarantee a minimal, deterministic set of included sources. Consider creating a temporary source directory under `target/` with a single file to ensure `getTargetFiles()` is exercised in a controlled way, and assert explicitly that the call does not throw. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
