elharo commented on code in PR #49:
URL:
https://github.com/apache/maven-assembly-plugin/pull/49#discussion_r2166430807
##########
src/test/java/org/apache/maven/plugins/assembly/archive/task/AddDependencySetsTaskTest.java:
##########
@@ -387,6 +388,54 @@ public void
testGetDependencyArtifacts_ShouldFilterOneDependencyArtifactViaInclu
assertSame(am1, result.iterator().next());
}
+ @Test
+ public void
testGetDependencyArtifacts_ShouldNotFilterOptionalArtifactsByDefault() throws
Exception {
+ Artifact am1 = mockArtifact(1);
Review Comment:
no need to use mocks here. You can simply create a DefaultArtifact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
