desruisseaux commented on code in PR #1092:
URL:
https://github.com/apache/maven-compiler-plugin/pull/1092#discussion_r3673509488
##########
src/main/java/org/apache/maven/plugin/compiler/CompilerMojo.java:
##########
@@ -109,6 +109,10 @@ public class CompilerMojo extends AbstractCompilerMojo {
/**
* A list of exclusion filters for the compiler.
+ * Excluding a source file only prevents the plugin from passing it
explicitly to the compiler. The compiler may
+ * still find it on the source path and generate a class file for it. This
can happen with {@code module-info.java}.
Review Comment:
This is a minor detail, but at least on `master` I tend to change line after
a dot or coma when possible. Therefore the comment could be (exact same text):
```java
* Excluding a source file only prevents the plugin from passing it
explicitly to the compiler.
* The compiler may still find it on the source path and generate a
class file for it.
* This can happen with {@code module-info.java}.
```
The reason for this formatting is that, if we edit the sentences again in
the future, `git diff` shows only the sentence that are impacted. Otherwise we
have a mix of potentially 3 sentences that are impacted and it is not
immediately obvious that the sentence just before or just after is actually
unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
