Copilot commented on code in PR #1092:
URL:
https://github.com/apache/maven-compiler-plugin/pull/1092#discussion_r3669093881
##########
src/main/java/org/apache/maven/plugin/compiler/TestCompilerMojo.java:
##########
@@ -96,6 +96,10 @@ public class TestCompilerMojo extends AbstractCompilerMojo {
/**
* A list of exclusion filters for the compiler.
+ * A file such as {@code module-info.java} may still be compiled if it is
implicitly referenced by the compiler,
+ * even if it has been excluded.
+ *
+ * @see AbstractCompilerMojo#implicit
Review Comment:
Same ambiguity as in `CompilerMojo`: “implicitly referenced by the compiler”
could be interpreted as the plugin. Prefer explicitly naming `javac` (or “the
Java compiler”) here to make the behavior and responsibility clearer.
##########
src/main/java/org/apache/maven/plugin/compiler/CompilerMojo.java:
##########
@@ -109,6 +109,10 @@ public class CompilerMojo extends AbstractCompilerMojo {
/**
* A list of exclusion filters for the compiler.
+ * A file such as {@code module-info.java} may still be compiled if it is
implicitly referenced by the compiler,
+ * even if it has been excluded.
+ *
+ * @see AbstractCompilerMojo#implicit
Review Comment:
The phrase “implicitly referenced by the compiler” is ambiguous in this
plugin (it could be read as the Maven Compiler Plugin itself rather than
`javac`). Consider wording this as “implicitly referenced by `javac`” (or “the
Java compiler”) to avoid confusion, since the distinction you’re documenting is
specifically about `javac`’s implicit source discovery vs plugin filtering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
