cstamas commented on code in PR #1902:
URL: https://github.com/apache/maven-resolver/pull/1902#discussion_r3419362846
##########
maven-resolver-generator-gnupg/src/main/java/org/eclipse/aether/generator/gnupg/GnupgSignatureArtifactGenerator.java:
##########
@@ -79,7 +80,7 @@ public String generatorId() {
}
@Override
- public Collection<? extends Artifact> generate(Collection<? extends
Artifact> generatedArtifacts) {
+ public synchronized Collection<? extends Artifact> generate(Collection<?
extends Artifact> generatedArtifacts) {
Review Comment:
While this generic assessment is right, artifact generator instances are
_created_ in installer/deployer (on method entry, so if install/deploy happens
on two or more thread -- each thread will have own generator), and after use
generated artifacts are passed along with existing artifacts to connector,
which again, will deploy in parallel.
So, the "If two threads invoke it concurrently" observation is true in
general, but I don't see where can it happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
