desruisseaux commented on issue #520: URL: https://github.com/apache/maven-jar-plugin/issues/520#issuecomment-4712926269
> Should `<detectMultiReleaseJar>` also be in the same boat then and be reevaluated? I modeled this change after that one. Good question. I don't know what was the rational at that time, but maybe it was because `<detectMultiReleaseJar>` does not control directly the `Multi-Release: true` attribute in `META-INF.MF` since Maven makes its own decision based on auto-detection. Also in principle, the effect is wider than only the `MANIFEST.MF` file because the JAR plugin should add the `*.class` files for other versions using the `--release` option (I'm not sure that the current plugin does that, but it should for allowing the `jar` tool to perform additional checks). By contrast, the `<mainClass>` element inside `<manifest>` should have an effect strictly limited to the `META-INF` file. I suggest to model an `<automaticModuleName>` on that instead. Note: if you decide to create a new pull request or edit the existing one, I suggest to target only the `master` branch instead of creating two pull requests for the two branches. It improves the chances that the discussion happens in one place, and the pull request created after the merge on master can be clearly identified as a backport. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
