dmlloyd commented on issue #520: URL: https://github.com/apache/maven-jar-plugin/issues/520#issuecomment-4712722644
> I'm not convinced this should ever be set by anything other than module-info.java but even if it should there would have to be another other way to do this. Are you saying that you don't understand what automatic modules are? There's some good reading about them here: https://stackoverflow.com/questions/46741907/what-is-an-automatic-module They're a critical migration step and Maven should have a way to easily define them. I think your given standard - that things should be *forbidden* from being properties on the basis of not wanting users to set them from the command line - is unreasonable, and is also violated many many times over by nearly every parameter in nearly every standard Maven plugin, most of which should definitely not *normally* be command-line settable. I don't think it makes sense to have _my_ change, small as it is, be ground zero for introducing some new policy though. But even if your standard were somehow arguably reasonable, it would be far more appropriate to suggest another mechanism for it (assuming you have a better idea), than to unilaterally close the issue and PR with just a few vague bits of opinionated feedback. Surely you understand the importance of improving modularity support in Maven. This is poor maintainer behavior no matter how you slice it, and I hope you reflect on that and reconsider. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
