bentatham opened a new pull request, #1852:
URL: https://github.com/apache/maven-resolver/pull/1852
Fixes `...293.225.2.0-dev for version range null: Comparison method violates
its general contract!` when there is a modifier on the version (eg when using
`mvn versions:update-parent`).
When two versions differ in kind at index 0 (e.g. a string-prefixed
branch-style version versus a numeric release whose first segment is zero),
comparePadding with a number filter may return 0 even though the versions are
clearly different. That makes equality non-transitive and breaks TimSort when
DefaultVersionRangeResolver sorts metadata lists mixing both shapes.
This is the same fix as MRESOLVER-336, which was applied to 2.x but never
landed on the 1.9.x line that ships with Maven 3.9.x.
Adds two regression tests covering the three-way transitivity violation and
a representative sort.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Your pull request should address just one issue, without pulling in
other changes.
- [X] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [X] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [X] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [X] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [X] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [X] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
