[
http://jira.codehaus.org/browse/MCHANGES-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Bentmann updated MCHANGES-66:
--------------------------------------
Attachment: sax-parsing.patch
changes.xml
Dennis, here is the changes.xml you requested. To see the unwanted newlines,
checkout for lines that are longer than the others in the generated changes
report.
Attached is another try for a patch. It's a variation of Henning's first patch.
To my knowledge, a SAX parser may split the input strings at ANY position when
reporting character chunks (see also [Top Ten SAX2
Tips|http://www.xml.com/pub/a/2001/12/05/sax2.html#d0e56]). For instance, the
string "Word" may be reported as the two chunks "Wo" and "rd" (that's why
inserting a newline after each chunk is a bad idea). Likewise, it might happen
that the string "Two Words" gets reported as "Two", " " and "Words" (that's why
trimming the chunks before concatenation is a bad idea because it would yield
"TwoWords"). So whatever string transformations the plugin needs, it should be
done at the end after the entire input string has been read and reconstructed.
> The changes plugin scatters white space over its Changes report
> ---------------------------------------------------------------
>
> Key: MCHANGES-66
> URL: http://jira.codehaus.org/browse/MCHANGES-66
> Project: Maven 2.x Changes Plugin
> Issue Type: Bug
> Components: changes-report
> Reporter: Henning Schmiedehausen
> Assignee: Dennis Lundberg
> Attachments: changes.xml, changes4.patch, changes7.patch,
> sax-parsing.patch
>
>
> The changelog plugin reads the contents of the changes.xml file and scatters
> \n characters into it. The attached patch fixes this and also improves
> performance by using a string buffer.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
