yeikel opened a new pull request, #397:
URL: https://github.com/apache/maven-wrapper/pull/397

   ### Summary
   
   This PR adds support for using the `central` mirror defined in 
`settings.xml` when resolving Maven Wrapper distribution downloads.
   
   Today, the wrapper plugin only applies a configured mirror if it is defined 
as `*`. This change allows the wrapper to work correctly in those environments 
by honoring the `central` mirror as well.
   
   ### What changed
   
   * The wrapper now detects and applies a mirror configured for `central` in 
`settings.xml`
   * If both `*` and `central` mirrors are present, the existing `*` behaviour 
remains supported
   
   Fixes #396
   
   - [x] Your pull request should address just one issue, without pulling in 
other changes.
   - [x] Write a pull request description that is detailed enough to understand 
what the pull request does, how, and why.
   - [x] Each commit in the pull request should have a meaningful subject line 
and body. 
     Note that commits might be squashed by a maintainer on merge.
   - [x] Write unit tests that match behavioral changes, where the tests fail 
if the changes to the runtime are not applied. 
     This may not always be possible but is a best-practice.
   - [x] Run `mvn verify` to make sure basic checks pass.
     A more thorough check will be performed on your pull request automatically.
   - [x] You have run the integration tests successfully (`mvn -Prun-its 
verify`).
   
   - [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   - [x] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to