sparsick commented on code in PR #1197:
URL:
https://github.com/apache/maven-site-plugin/pull/1197#discussion_r2624231557
##########
pom.xml:
##########
@@ -478,7 +478,23 @@ under the License.
<version>${jettyVersion}</version>
<scope>test</scope>
</dependency>
-
+ <dependency>
+ <groupId>org.junit.jupiter</groupId>
+ <artifactId>junit-jupiter-api</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.junit.vintage</groupId>
+ <artifactId>junit-vintage-engine</artifactId>
+ <scope>test</scope>
+ </dependency>
Review Comment:
yes, without I will get following error:
```
com.google.inject.CreationException:
Unable to create injector, see the following errors:
1) An exception was caught and reported. Message:
java.lang.reflect.InvocationTargetException
at
org.apache.maven.api.plugin.testing.MojoExtension.lambda$beforeEach$1(MojoExtension.java:206)
(via modules:
org.apache.maven.api.plugin.testing.MojoExtension$$Lambda/0x00007c0af02a6a60 ->
org.apache.maven.api.plugin.testing.MojoExtension$MavenProvidesModule)
1 error
at
com.google.inject.internal.Errors.throwCreationExceptionIfErrorsExist(Errors.java:543)
at
com.google.inject.internal.InternalInjectorCreator.initializeStatically(InternalInjectorCreator.java:159)
at
com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:106)
at com.google.inject.Guice.createInjector(Guice.java:87)
at com.google.inject.Guice.createInjector(Guice.java:69)
at com.google.inject.Guice.createInjector(Guice.java:59)
at
org.codehaus.plexus.DefaultPlexusContainer.addPlexusInjector(DefaultPlexusContainer.java:493)
at
org.apache.maven.api.plugin.testing.MojoExtension.beforeEach(MojoExtension.java:204)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Suppressed: java.lang.IllegalStateException
at
org.apache.maven.session.scope.internal.SessionScope.exit(SessionScope.java:107)
at
org.apache.maven.api.plugin.testing.MojoExtension.afterEach(MojoExtension.java:260)
... 2 more
Caused by: java.lang.IllegalArgumentException:
java.lang.reflect.InvocationTargetException
at
org.apache.maven.api.plugin.testing.MojoExtension$MavenProvidesModule.configure(MojoExtension.java:616)
at
com.google.inject.spi.Elements$RecordingBinder.install(Elements.java:344)
at
org.apache.maven.api.plugin.testing.MojoExtension.lambda$beforeEach$1(MojoExtension.java:206)
at
com.google.inject.spi.Elements$RecordingBinder.install(Elements.java:344)
at com.google.inject.spi.Elements.getElements(Elements.java:103)
at com.google.inject.spi.Elements.getElements(Elements.java:96)
at org.eclipse.sisu.wire.WireModule.configure(WireModule.java:77)
at
com.google.inject.spi.Elements$RecordingBinder.install(Elements.java:344)
at com.google.inject.spi.Elements.getElements(Elements.java:103)
at
com.google.inject.internal.InjectorShell$Builder.build(InjectorShell.java:137)
at
com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:103)
... 7 more
Caused by: java.lang.reflect.InvocationTargetException
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at
org.apache.maven.api.plugin.testing.MojoExtension$MavenProvidesModule.configure(MojoExtension.java:610)
... 17 more
Caused by: java.lang.NoClassDefFoundError: junit/framework/TestCase
at
org.apache.maven.plugin.testing.stubs.MavenProjectStub.getBasedir(MavenProjectStub.java:291)
at
org.apache.maven.plugins.site.stubs.SiteMavenProjectStub.<init>(SiteMavenProjectStub.java:43)
at
org.apache.maven.plugins.site.deploy.SiteDeployWebDavThruProxyWitAuthzInProxyTest.project(SiteDeployWebDavThruProxyWitAuthzInProxyTest.java:103)
... 19 more
Caused by: java.lang.ClassNotFoundException: junit.framework.TestCase
... 22 more
```
I will add a comment to explain it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
