elharo commented on code in PR #415:
URL:
https://github.com/apache/maven-build-cache-extension/pull/415#discussion_r2610988143
##########
src/main/java/org/apache/maven/buildcache/CacheControllerImpl.java:
##########
@@ -102,7 +102,7 @@
import static org.apache.maven.buildcache.CacheResult.empty;
import static org.apache.maven.buildcache.CacheResult.failure;
import static org.apache.maven.buildcache.CacheResult.partialSuccess;
-import static org.apache.maven.buildcache.CacheResult.rebuilded;
+import static org.apache.maven.buildcache.CacheResult.rebuilt;
Review Comment:
I would not static import any of these, but let's not make it worse by
adding a new one
##########
src/main/java/org/apache/maven/buildcache/CacheResult.java:
##########
@@ -70,12 +70,20 @@ public static CacheResult failure(CacheContext context) {
return new CacheResult(RestoreStatus.FAILURE, null, context);
}
- public static CacheResult rebuilded(CacheResult orig, Build build) {
+ public static CacheResult rebuilt(CacheResult orig, Build build) {
Review Comment:
orig --> original
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
