elharo commented on code in PR #1479: URL: https://github.com/apache/maven-site/pull/1479#discussion_r2596283357
########## content/markdown/guides/introduction/introduction-to-profiles.md: ########## @@ -43,17 +43,19 @@ To address these circumstances, Maven supports build profiles. Profiles are spec ## Profile Inheritance -The profiles are not inherited as other POM elements by child POMs. Instead they are resolved very early by the [Maven Model Builder](/ref/current/maven-model-builder/) and only the effects of active profiles are inherited (e.g. the plugins defined in the profile). That also leads to the fact that implicit profile activation only has an effect on the surrounding profile container but never on any other profile (even if it has the same id). +The profiles are not inherited as other POM elements by child POMs. Instead, they are resolved very early by the [Maven Model Builder](/ref/current/maven-model-builder/) and only the effects of active profiles are inherited (e.g. the plugins defined in the profile). That also leads to the fact that implicit profile activation only has an effect on the surrounding profile container but never on any other profile (even if it has the same id). Review Comment: delete "That also leads to the fact that " ########## content/markdown/guides/introduction/introduction-to-profiles.md: ########## @@ -43,17 +43,19 @@ To address these circumstances, Maven supports build profiles. Profiles are spec ## Profile Inheritance -The profiles are not inherited as other POM elements by child POMs. Instead they are resolved very early by the [Maven Model Builder](/ref/current/maven-model-builder/) and only the effects of active profiles are inherited (e.g. the plugins defined in the profile). That also leads to the fact that implicit profile activation only has an effect on the surrounding profile container but never on any other profile (even if it has the same id). +The profiles are not inherited as other POM elements by child POMs. Instead, they are resolved very early by the [Maven Model Builder](/ref/current/maven-model-builder/) and only the effects of active profiles are inherited (e.g. the plugins defined in the profile). That also leads to the fact that implicit profile activation only has an effect on the surrounding profile container but never on any other profile (even if it has the same id). ## How can a profile be triggered? How does this vary according to the type of profile being used? A profile can be activated in several ways: - Explicitly -- Implicitly - - Based on OS - - Based on system properties - - Based on presence of files +- Implicitly, based on + - JDK version, Review Comment: no commas at end of this is a bulleted list -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
